Revert "usb: common: usb-conn-gpio: Set last role to unknown before initial detection"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Jun 2023 09:30:35 +0000 (11:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:56 +0000 (16:21 +0200)
commite34817340025e6cc4edaef6fa5eace09d42917c9
tree16e6a8153fdc89323fbfb1629dd70fde2bac469a
parent22b1e2af69eced0c064b7c4be411caf7ffdee21b
Revert "usb: common: usb-conn-gpio: Set last role to unknown before initial detection"

[ Upstream commit df49f2a0ac4a34c0cb4b5c233fcfa0add644c43c ]

This reverts commit edd60d24bd858cef165274e4cd6cab43bdc58d15.

Heikki reports that this should not be a global flag just to work around
one broken driver and should be fixed differently, so revert it.

Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Fixes: edd60d24bd85 ("usb: common: usb-conn-gpio: Set last role to unknown before initial detection")
Link: https://lore.kernel.org/r/ZImE4L3YgABnCIsP@kuha.fi.intel.com
Cc: Prashanth K <quic_prashk@quicinc.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/cdns3/core.c
drivers/usb/common/usb-conn-gpio.c
drivers/usb/musb/jz4740.c
drivers/usb/roles/intel-xhci-usb-role-switch.c
include/linux/usb/role.h