hurd: Fix sc_i386_thread_state layout
authorSergey Bugaev <bugaevc@gmail.com>
Mon, 15 May 2023 08:33:22 +0000 (11:33 +0300)
committerSamuel Thibault <samuel.thibault@ens-lyon.org>
Tue, 16 May 2023 14:09:00 +0000 (16:09 +0200)
commite333759f7752593a69a8f9920a247ed3878fafef
tree0c307ea5d660fea298c4069b301863a38c84284f
parentce96593c882b393461084048533120e9c1e9d328
hurd: Fix sc_i386_thread_state layout

The real i386_thread_state Mach structure has an alignment of 8 on
x86_64. However, in struct sigcontext, the compiler was packing sc_gs
(which is the first member of sc_i386_thread_state) into the same 8-byte
slot as sc_error; this resulted in the rest of sc_i386_thread_state
members having wrong offsets relative to each other, and the overall
sc_i386_thread_state layout mismatching that of i386_thread_state.

Fix this by explicitly adding the required padding members, and
statically asserting that this results in the desired alignment.

The same goes for sc_i386_float_state.

Checked on x86_64-gnu.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230515083323.1358039-4-bugaevc@gmail.com>
sysdeps/mach/hurd/x86/trampoline.c
sysdeps/mach/hurd/x86_64/bits/sigcontext.h