i2c: mpc: Use atomic read and fix break condition
authorChris Packham <chris.packham@alliedtelesis.co.nz>
Tue, 7 Dec 2021 04:21:44 +0000 (17:21 +1300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 09:57:15 +0000 (10:57 +0100)
commite3098ce15fece36ded5e0d298568209e38dbb014
treed54188e5fa31d101414966b334742f5dfbcf7b3d
parent23a5f9797d6cad693d990486836311d750c4407f
i2c: mpc: Use atomic read and fix break condition

commit a74c313aca266fab0d1d1a72becbb8b7b5286b6e upstream.

Maxime points out that the polling code in mpc_i2c_isr should use the
_atomic API because it is called in an irq context and that the
behaviour of the MCF bit is that it is 1 when the byte transfer is
complete. All of this means the original code was effectively a
udelay(100).

Fix this by using readb_poll_timeout_atomic() and removing the negation
of the break condition.

Fixes: 4a8ac5e45cda ("i2c: mpc: Poll for MCF")
Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Tested-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/i2c/busses/i2c-mpc.c