block, bfq: fix uaf for 'stable_merge_bfqq'
authorYu Kuai <yukuai3@huawei.com>
Wed, 8 Mar 2023 02:32:08 +0000 (10:32 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 8 Mar 2023 14:34:50 +0000 (07:34 -0700)
commite2f2a39452c43b64ea3191642a2661cb8d03827a
treebb85a3d9c05661e2c356f44fa95b0da4e059064d
parente33062213ff2f9151e0d125e1c00f524c2b7acfe
block, bfq: fix uaf for 'stable_merge_bfqq'

Before commit fd571df0ac5b ("block, bfq: turn bfqq_data into an array
in bfq_io_cq"), process reference is read before bfq_put_stable_ref(),
and it's safe if bfq_put_stable_ref() put the last reference, because
process reference will be 0 and 'stable_merge_bfqq' won't be accessed
in this case. However, the commit changed the order and  will cause
uaf for 'stable_merge_bfqq'.

In order to emphasize that bfq_put_stable_ref() can drop the last
reference, fix the problem by moving bfq_put_stable_ref() to the end of
bfq_setup_stable_merge().

Fixes: fd571df0ac5b ("block, bfq: turn bfqq_data into an array in bfq_io_cq")
Reported-and-tested-by: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Link: https://lore.kernel.org/linux-block/20230307071448.rzihxbm4jhbf5krj@shindev/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c