genirq: Prevent nested thread vs synchronize_hardirq() deadlock
authorVincent Whitchurch <vincent.whitchurch@axis.com>
Thu, 6 Jul 2023 14:22:25 +0000 (16:22 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 31 Jul 2023 15:24:22 +0000 (17:24 +0200)
commite2c12739ccf76aae12e9e949526a475b9d17adaa
treead2ecf7f226cf6f090b9cc506026d67a4e6cd399
parent5d0c230f1de8c7515b6567d9afba1f196fb4e2f4
genirq: Prevent nested thread vs synchronize_hardirq() deadlock

There is a possibility of deadlock if synchronize_hardirq() is called
when the nested threaded interrupt is active.  The following scenario
was observed on a uniprocessor PREEMPT_NONE system:

 Thread 1                      Thread 2

 handle_nested_thread()
  Set INPROGRESS
  Call ->thread_fn()
   thread_fn goes to sleep

                              free_irq()
                               __synchronize_hardirq()
                                Busy-loop forever waiting for INPROGRESS
                                to be cleared

The INPROGRESS flag is only supposed to be used for hard interrupt
handlers.  Remove the incorrect usage in the nested threaded interrupt
case and instead re-use the threads_active / wait_for_threads mechanism
to wait for nested threaded interrupts to complete.

Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230613-genirq-nested-v3-1-ae58221143eb@axis.com
kernel/irq/chip.c
kernel/irq/internals.h
kernel/irq/manage.c