Add <bits/indirect-return.h>
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 24 Jul 2018 14:55:35 +0000 (07:55 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 24 Jul 2018 14:55:47 +0000 (07:55 -0700)
commite27f41ba2b6101be1a511905bff5502ffd23828b
treef7bd74631da12cc22e2dc5f6556a9ea2b45de5f0
parent21526a507df8f1b2e37492193a754534d8938c0b
Add <bits/indirect-return.h>

Add <bits/indirect-return.h> and include it in <ucontext.h>.
__INDIRECT_RETURN defined in <bits/indirect-return.h> indicates if
swapcontext requires special compiler treatment.  The default
__INDIRECT_RETURN is empty.

On x86, when shadow stack is enabled, __INDIRECT_RETURN is defined
with indirect_return attribute, which has been added to GCC 9, to
indicate that swapcontext returns via indirect branch.  Otherwise
__INDIRECT_RETURN is defined with returns_twice attribute.

When shadow stack is enabled, remove always_inline attribute from
prepare_test_buffer in string/tst-xbzero-opt.c to avoid:

tst-xbzero-opt.c: In function ‘prepare_test_buffer’:
tst-xbzero-opt.c:105:1: error: function ‘prepare_test_buffer’ can never be inlined because it uses setjmp
 prepare_test_buffer (unsigned char *buf)

when indirect_return attribute isn't available.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
* bits/indirect-return.h: New file.
* misc/sys/cdefs.h (__glibc_has_attribute): New.
* sysdeps/x86/bits/indirect-return.h: Likewise.
* stdlib/Makefile (headers): Add bits/indirect-return.h.
* stdlib/ucontext.h: Include <bits/indirect-return.h>.
(swapcontext): Add __INDIRECT_RETURN.
* string/tst-xbzero-opt.c (ALWAYS_INLINE): New.
(prepare_test_buffer): Use it.
ChangeLog
bits/indirect-return.h [new file with mode: 0644]
misc/sys/cdefs.h
stdlib/Makefile
stdlib/ucontext.h
string/tst-xbzero-opt.c
sysdeps/x86/bits/indirect-return.h [new file with mode: 0644]