mtd: rawnand: qcom: Fix address parsing within ->exec_op()
authorMiquel Raynal <miquel.raynal@bootlin.com>
Sun, 16 Jul 2023 14:46:12 +0000 (16:46 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 28 Jul 2023 12:32:29 +0000 (14:32 +0200)
commite2532429312d089cf0d13bcb411433d85aef98f0
treea04a97eb1c4a4ddb10cb937812562441a86d5648
parente260efea80e9cab8ad9dea1a03db11225df720f3
mtd: rawnand: qcom: Fix address parsing within ->exec_op()

The naddrs variable is initialized but not used. Fixing this could have
been a matter of dropping the variable, but the right way to do it looks
a bit more complex: we can avoid useless writes to the q_op structure by
using it. In practice we could even have possible out-of-bound bugs with
the existing implementation. Let's fix all that by just performing the
right number of assignments in the addr{1,2}_reg fields.

Fixes: 89550beb098e ("mtd: rawnand: qcom: Implement exec_op()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307131959.PdPSC86K-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202307131730.NOYbcjBr-lkp@intel.com/
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/linux-mtd/20230716144612.32132-9-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/qcom_nandc.c