Annotate System.Net.Sockets for nullable reference types (#32675)
authorEric Erhardt <eric.erhardt@microsoft.com>
Thu, 27 Feb 2020 03:19:18 +0000 (21:19 -0600)
committerGitHub <noreply@github.com>
Thu, 27 Feb 2020 03:19:18 +0000 (21:19 -0600)
commite22cf553e11d500c1523034f2c7ff745014e0629
treecf9e0196793c9b255a19cd180a548fac60fd6c71
parentb6356625e9aec84012c1d6712f03d98c69929092
Annotate System.Net.Sockets for nullable reference types (#32675)

* All AsyncResult classes have nullable enable.

* Most ancillary files annotated.

* UdpClient annotated

* Annotate TcpClient

* Annotate TcpListener, SafeSocketHandle, SocketTaskExtensions

* Annotate NetworkStream and SendPacketsElement

* Annotate SocketPal.

* Annotate SocketAsyncEventArgs

* Annotate SocketAsyncEngine and Context on Unix

* Annotate Socket.Tasks

* Finish annotating the Socket class.

* Remove inline #nullable lines

* Annotate all public methods.

* Sync up to latest code and cleanup.

* Fix .NET Framework build for WinHttpHandler.
58 files changed:
src/libraries/Common/src/Interop/Windows/WinSock/Interop.TransmitFile.cs
src/libraries/Common/src/Interop/Windows/WinSock/Interop.WSAIoctl.cs
src/libraries/Common/src/Interop/Windows/WinSock/Interop.setsockopt.cs
src/libraries/Common/src/Interop/Windows/WinSock/SafeNativeOverlapped.cs
src/libraries/Common/src/System/Net/ContextAwareResult.Windows.cs
src/libraries/Common/src/System/Net/ContextAwareResult.cs
src/libraries/Common/src/System/Net/DebugSafeHandleMinusOneIsInvalid.cs
src/libraries/Common/src/System/Net/Internals/SocketExceptionFactory.cs
src/libraries/Common/src/System/Net/LazyAsyncResult.cs
src/libraries/Common/src/System/Net/Logging/NetEventSource.Common.cs
src/libraries/System.IO.Pipes/src/System/IO/Pipes/NamedPipeClientStream.Unix.cs
src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeStream.Unix.cs
src/libraries/System.Net.Sockets/ref/System.Net.Sockets.cs
src/libraries/System.Net.Sockets/ref/System.Net.Sockets.csproj
src/libraries/System.Net.Sockets/src/System.Net.Sockets.csproj
src/libraries/System.Net.Sockets/src/System/Net/Sockets/AcceptOverlappedAsyncResult.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/AcceptOverlappedAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/AcceptOverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/ConnectOverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/DisconnectOverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/DynamicWinsockMethods.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/IOControlKeepAlive.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/IPPacketInformation.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MulticastOption.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/MultipleConnectAsync.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/NetEventSource.Sockets.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/NetworkStream.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/OverlappedAsyncResult.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/OverlappedAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/OverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/ReceiveMessageOverlappedAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/ReceiveMessageOverlappedAsyncResult.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SafeSocketHandle.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SendPacketsElement.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEngine.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Unix.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketPal.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketTaskExtensions.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPClient.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPListener.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/TransmitFileAsyncResult.Windows.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UDPClient.cs
src/libraries/System.Net.Sockets/src/System/Net/Sockets/UdpReceiveResult.cs
src/libraries/System.Net.Sockets/tests/FunctionalTests/DisconnectTest.cs