[lldb] Group ABI plugins
authorPavel Labath <labath@google.com>
Sun, 2 Feb 2020 07:48:51 +0000 (08:48 +0100)
committerPavel Labath <labath@google.com>
Fri, 7 Feb 2020 17:51:38 +0000 (09:51 -0800)
commite21b39a86dd6e8d1a5a5fe7e0286f8570732834d
tree69a62ce241a2d63a6ddcb56767cc5f026105356e
parent2e005c64f3019aada8df29a24dcfe56f044e2e59
[lldb] Group ABI plugins

Summary:
There's a fair amount of code duplication between the different ABI plugins for
the same architecture (e.g. ABIMacOSX_arm & ABISysV_arm). Deduplicating this
code is not very easy at the moment because there is no good place where to put
the common code.

Instead of creating more plugins, this patch reduces their number by grouping
similar plugins into a single folder/plugin. This makes it easy to extract
common code to a (e.g.) base class, which can then live in the same folder.

The grouping is done based on the underlying llvm target for that architecture,
because the plugins already require this for their operation.

Reviewers: JDevlieghere, jasonmolenda, jfb

Subscribers: sdardis, nemanjai, mgorny, kristof.beyls, fedor.sergeev, kbarton, jrtc27, atanasyan, jsji, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74138
48 files changed:
lldb/source/API/SystemInitializerFull.cpp
lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp [moved from lldb/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp with 100% similarity]
lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.h [moved from lldb/source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h with 100% similarity]
lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp [moved from lldb/source/Plugins/ABI/SysV-arm64/ABISysV_arm64.cpp with 100% similarity]
lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.h [moved from lldb/source/Plugins/ABI/SysV-arm64/ABISysV_arm64.h with 100% similarity]
lldb/source/Plugins/ABI/AArch64/CMakeLists.txt [moved from lldb/source/Plugins/ABI/MacOSX-arm64/CMakeLists.txt with 62% similarity]
lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp [moved from lldb/source/Plugins/ABI/SysV-arc/ABISysV_arc.cpp with 100% similarity]
lldb/source/Plugins/ABI/ARC/ABISysV_arc.h [moved from lldb/source/Plugins/ABI/SysV-arc/ABISysV_arc.h with 100% similarity]
lldb/source/Plugins/ABI/ARC/CMakeLists.txt [moved from lldb/source/Plugins/ABI/SysV-arc/CMakeLists.txt with 74% similarity]
lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.cpp [moved from lldb/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.cpp with 100% similarity]
lldb/source/Plugins/ABI/ARM/ABIMacOSX_arm.h [moved from lldb/source/Plugins/ABI/MacOSX-arm/ABIMacOSX_arm.h with 100% similarity]
lldb/source/Plugins/ABI/ARM/ABISysV_arm.cpp [moved from lldb/source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp with 100% similarity]
lldb/source/Plugins/ABI/ARM/ABISysV_arm.h [moved from lldb/source/Plugins/ABI/SysV-arm/ABISysV_arm.h with 100% similarity]
lldb/source/Plugins/ABI/ARM/CMakeLists.txt [moved from lldb/source/Plugins/ABI/MacOSX-arm/CMakeLists.txt with 70% similarity]
lldb/source/Plugins/ABI/CMakeLists.txt
lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.cpp [moved from lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp with 100% similarity]
lldb/source/Plugins/ABI/Hexagon/ABISysV_hexagon.h [moved from lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.h with 100% similarity]
lldb/source/Plugins/ABI/Hexagon/CMakeLists.txt [moved from lldb/source/Plugins/ABI/SysV-hexagon/CMakeLists.txt with 69% similarity]
lldb/source/Plugins/ABI/MacOSX-i386/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/Mips/ABISysV_mips.cpp [moved from lldb/source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp with 100% similarity]
lldb/source/Plugins/ABI/Mips/ABISysV_mips.h [moved from lldb/source/Plugins/ABI/SysV-mips/ABISysV_mips.h with 100% similarity]
lldb/source/Plugins/ABI/Mips/ABISysV_mips64.cpp [moved from lldb/source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp with 100% similarity]
lldb/source/Plugins/ABI/Mips/ABISysV_mips64.h [moved from lldb/source/Plugins/ABI/SysV-mips64/ABISysV_mips64.h with 100% similarity]
lldb/source/Plugins/ABI/Mips/CMakeLists.txt [moved from lldb/source/Plugins/ABI/SysV-mips64/CMakeLists.txt with 64% similarity]
lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp [moved from lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp with 100% similarity]
lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.h [moved from lldb/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.h with 100% similarity]
lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.cpp [moved from lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp with 100% similarity]
lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc64.h [moved from lldb/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.h with 100% similarity]
lldb/source/Plugins/ABI/PowerPC/CMakeLists.txt [moved from lldb/source/Plugins/ABI/SysV-ppc64/CMakeLists.txt with 68% similarity]
lldb/source/Plugins/ABI/SysV-arm/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SysV-arm64/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SysV-i386/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SysV-mips/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SysV-ppc/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SysV-x86_64/CMakeLists.txt [deleted file]
lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.cpp [moved from lldb/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.cpp with 100% similarity]
lldb/source/Plugins/ABI/SystemZ/ABISysV_s390x.h [moved from lldb/source/Plugins/ABI/SysV-s390x/ABISysV_s390x.h with 100% similarity]
lldb/source/Plugins/ABI/SystemZ/CMakeLists.txt [moved from lldb/source/Plugins/ABI/SysV-s390x/CMakeLists.txt with 69% similarity]
lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.cpp [moved from lldb/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp with 100% similarity]
lldb/source/Plugins/ABI/X86/ABIMacOSX_i386.h [moved from lldb/source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.h with 100% similarity]
lldb/source/Plugins/ABI/X86/ABISysV_i386.cpp [moved from lldb/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp with 100% similarity]
lldb/source/Plugins/ABI/X86/ABISysV_i386.h [moved from lldb/source/Plugins/ABI/SysV-i386/ABISysV_i386.h with 100% similarity]
lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp [moved from lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp with 100% similarity]
lldb/source/Plugins/ABI/X86/ABISysV_x86_64.h [moved from lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.h with 100% similarity]
lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.cpp [moved from lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp with 100% similarity]
lldb/source/Plugins/ABI/X86/ABIWindows_x86_64.h [moved from lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.h with 100% similarity]
lldb/source/Plugins/ABI/X86/CMakeLists.txt [moved from lldb/source/Plugins/ABI/Windows-x86_64/CMakeLists.txt with 52% similarity]
lldb/tools/lldb-test/SystemInitializerTest.cpp