Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"
authorAnders Kaseorg <andersk@mit.edu>
Mon, 2 Dec 2019 22:09:20 +0000 (17:09 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Jan 2020 18:18:35 +0000 (19:18 +0100)
commite1d93f13f647dfe133b4626612fa1ee1bd31b230
tree3ec02b4e6222271fb2047f23ffbd8c7fc467fef5
parent33ecb96148d61defc779bf4df47ba0d6e02129a4
Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"

commit db5cce1afc8d2475d2c1c37c2a8267dd0e151526 upstream.

This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.

Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
attempted to fix the same bug (dead assignments to the local variable
cfg), but they did so in incompatible ways. When they were both merged,
independently of each other, the combination actually caused the bug to
reappear, leading to a firmware crash on boot for some cards.

https://bugzilla.kernel.org/show_bug.cgi?id=205719

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/intel/iwlwifi/pcie/drv.c