nir/builder: Use nir_after_instr to advance the cursor
authorJason Ekstrand <jason.ekstrand@intel.com>
Mon, 31 Aug 2015 23:54:02 +0000 (16:54 -0700)
committerJason Ekstrand <jason.ekstrand@intel.com>
Tue, 1 Sep 2015 01:17:07 +0000 (18:17 -0700)
commite16531fbe3a79bc27cf00701616a260b452597ef
tree80ad0634b9e9565596495e0d154ae6e52fc12e10
parentf3a483069a6f0d38c10cec88417ae2b5b5aa3392
nir/builder: Use nir_after_instr to advance the cursor

This *should* ensure that the cursor gets properly advanced in all cases.
We had a problem before where, if the cursor was created using
nir_after_cf_node on a non-block cf_node, that would call nir_before_block
on the block following the cf node.  Instructions would then get inserted
in backwards order at the top of the block which is not at all what you
would expect from nir_after_cf_node.  By just resetting to after_instr, we
avoid all these problems.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/glsl/nir/nir_builder.h