USB: serial: digi_acceleport: fix OOB data sanity check
authorJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 16:17:27 +0000 (17:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Mar 2017 11:14:26 +0000 (19:14 +0800)
commite1533c46151cedb8904f3f88d6c2fc0753e46c0f
treed2a6eb1880535b393075ff5356456a0c04265997
parentd962bf8dd954db6db513b42cc484a9528df3e5a3
USB: serial: digi_acceleport: fix OOB data sanity check

commit 2d380889215fe20b8523345649dee0579821800c upstream.

Make sure to check for short transfers to avoid underflow in a loop
condition when parsing the receive buffer.

Also fix an off-by-one error in the incomplete sanity check which could
lead to invalid data being parsed.

Fixes: 8c209e6782ca ("USB: make actual_length in struct urb field u32")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/digi_acceleport.c