drm/i915/gem: Keep request alive while attaching fences
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 17 Dec 2019 13:47:29 +0000 (13:47 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 17 Dec 2019 15:10:00 +0000 (15:10 +0000)
commite14177f19739d74839eb496a27f5f5d958beaa5b
treeb26a18965bcb4ebb717010ea9738f6a746cbbf43
parentb69413110207058b915c85834339c04b1557e92b
drm/i915/gem: Keep request alive while attaching fences

Since commit e5dadff4b093 ("drm/i915: Protect request retirement with
timeline->mutex"), the request retirement can happen outside of the
struct_mutex serialised only by the timeline->mutex. We drop the
timeline->mutex on submitting the request (i915_request_add) so after
that point, it is liable to be freed. Make sure our local reference is
kept alive until we have finished attaching it to the signalers. (Note
that this erodes the argument that i915_request_add should consume the
reference, but that is a slightly larger patch!)

Fixes: e5dadff4b093 ("drm/i915: Protect request retirement with timeline->mutex")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191217134729.3297818-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c