powerpc/xmon: Setup debugger hooks when first break-point is set
authorVaibhav Jain <vaibhav@linux.vnet.ibm.com>
Sun, 4 Mar 2018 17:30:25 +0000 (23:00 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 13 Mar 2018 04:10:16 +0000 (15:10 +1100)
commite1368d0c9edbc366e45216e7295fd61ae55c2b12
tree8d19dcb1040d221eec0234781cfb12b567a76397
parentb395e55b49ecd56ea28dc629f4ca4c6239fc07c3
powerpc/xmon: Setup debugger hooks when first break-point is set

Presently sysrq key for xmon('x') is registered during kernel init
irrespective of the value of kernel param 'xmon'. Thus xmon is enabled
even if 'xmon=off' is passed on the kernel command line. However this
doesn't enable the kernel debugger hooks needed for instruction or
data breakpoints. Thus when a break-point is hit with xmon=off a
kernel oops of the form below is reported:

  Oops: Exception in kernel mode, sig: 5 [#1]
  < snip >
  Trace/breakpoint trap

To fix this the patch checks and enables debugger hooks when an
instruction or data break-point is set via xmon console.

Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
[mpe: Just printf directly, no need for static const char[]]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/xmon/xmon.c