NFC: trf7970a: fix check of clock frequencies, use && instead of ||
authorColin Ian King <colin.king@canonical.com>
Mon, 24 Apr 2017 13:36:02 +0000 (14:36 +0100)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 22 Jun 2017 21:59:01 +0000 (23:59 +0200)
commite1038535106e73e48204ec3bfe5a428fe6cb35cb
tree946b3da460748f407be8bfd4592a62f36a3d6513
parent1e4179bc71aeaba81bcf42f5f23a9a3bb1219814
NFC: trf7970a: fix check of clock frequencies, use && instead of ||

The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) ||
(clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because
clk_freq cannot be equal to two different values at the same time. Use
the  && operator instead of || to fix this.

Detected by CoverityScan, CID#1430468 ("Constant expression result")

Fixes: 837eb4d21ecde7 ("NFC: trf7970a: add device tree option for 27MHz clock")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Geoff Lansberry <geoff@kuvee.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/nfc/trf7970a.c