[lldb] Fix incorrect uses of LLDB_LOG_ERROR
authorJonas Devlieghere <jonas@devlieghere.com>
Wed, 5 Jul 2023 17:47:14 +0000 (10:47 -0700)
committerJonas Devlieghere <jonas@devlieghere.com>
Wed, 5 Jul 2023 18:27:52 +0000 (11:27 -0700)
commite0e36e3725b50ac690d1839f0e9476e93ff7988d
tree87d0ea7488478284a50d46769e692a8342801386
parent1ac3e13c3e4ab6816116a6e6997f81acf1039849
[lldb] Fix incorrect uses of LLDB_LOG_ERROR

Fix incorrect uses of LLDB_LOG_ERROR. The macro doesn't automatically
inject the error in the log message: it merely passes the error as the
first argument to formatv and therefore must be referenced with {0}.

Thanks to Nicholas Allegra for collecting a list of places where the
macro was misused.

rdar://111581655

Differential revision: https://reviews.llvm.org/D154530
15 files changed:
lldb/source/Breakpoint/Watchpoint.cpp
lldb/source/Core/ValueObjectRegister.cpp
lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp
lldb/source/Symbol/Type.cpp
lldb/source/Target/StackFrame.cpp
lldb/source/Target/Target.cpp
lldb/source/Target/ThreadPlanTracer.cpp