regulator: s5m8767: fix get_register() error handling
authorArnd Bergmann <arnd@arndb.de>
Tue, 16 Feb 2016 14:53:11 +0000 (15:53 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 16 Feb 2016 17:08:59 +0000 (17:08 +0000)
commite07ff9434167981c993a26d2edbbcb8e13801dbb
tree0d949b6bc2ffd2f62db65ef9539bafb39e8ab7c4
parent92e963f50fc74041b5e9e744c330dca48e04f08d
regulator: s5m8767: fix get_register() error handling

The s5m8767_pmic_probe() function calls s5m8767_get_register() to
read data without checking the return code, which produces a compile-time
warning when that data is accessed:

drivers/regulator/s5m8767.c: In function 's5m8767_pmic_probe':
drivers/regulator/s5m8767.c:924:7: error: 'enable_reg' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/regulator/s5m8767.c:944:30: error: 'enable_val' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This changes the s5m8767_get_register() function to return a -EINVAL
not just for an invalid register number but also for an invalid
regulator number, as both would result in returning uninitialized
data. The s5m8767_pmic_probe() function is then changed accordingly
to fail on a read error, as all the other callers of s5m8767_get_register()
already do.

In practice this probably cannot happen, as we don't call
s5m8767_get_register() with invalid arguments, but the gcc
warning seems valid in principle, in terms writing safe
error checking.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9c4c60554acf ("regulator: s5m8767: Convert to use regulator_[enable|disable|is_enabled]_regmap")
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/s5m8767.c