[MC][ELF] Improve st_size propagation rule
authorFangrui Song <i@maskray.me>
Fri, 8 Apr 2022 17:06:43 +0000 (10:06 -0700)
committerFangrui Song <i@maskray.me>
Fri, 8 Apr 2022 17:06:44 +0000 (10:06 -0700)
commite07dfa5328b0ca1465ae7b749e1ac2d994741e27
tree7faf94e0d8cbde7f89922236941d3e078ebc801e
parent67acc34e2ad89f18a6d66d72ddc30e77c5aff7d9
[MC][ELF] Improve st_size propagation rule

`.symver foo, foo@ver` creates the MCSymbolELF `foo@ver` whose almost all
attributes (including st_size) should inherit from `foo` (GNU as behavior).

a041ef1bd8905f0d58e301c6830b183002ff1847 added st_size propagation which works
for many cases but fails for the following one:

```
.set __GLIBC_2_12_sys_errlist, _sys_errlist_internal
.type   __GLIBC_2_12_sys_errlist,@object
.size   __GLIBC_2_12_sys_errlist, 1080
.symver __GLIBC_2_12_sys_errlist, sys_errlist@GLIBC_2.12
...
_sys_errlist_internal:
.size   _sys_errlist_internal, 1072
```

`sys_errlist@GLIBC_2.12`'s st_size is 1072 (incorrect), which does not match
`__GLIBC_2_12_sys_errlist`'s st_size: 1080.

The problem is that `Base` is (the final) `_sys_errlist_internal` while we want
to respect (the intermediate) `__GLIBC_2_12_sys_errlist`'s st_size.
Fix this by following the MCSymbolRefExpr assignment chain and finding
the closest non-null `getSize()`, which covers most needs. Notably MCBinaryExpr
is not handled, but it is rare enough to matter.

Reviewed By: peter.smith

Differential Revision: https://reviews.llvm.org/D123283
llvm/lib/MC/ELFObjectWriter.cpp
llvm/test/MC/ELF/offset.s