glupload: Only renegotiate if the caps are incompatible
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Wed, 31 Oct 2018 18:30:14 +0000 (18:30 +0000)
committerNicolas Dufresne <nicolas.dufresne@collabora.com>
Thu, 1 Nov 2018 10:22:28 +0000 (06:22 -0400)
commite074eff5ef1f37e3d1da3c4953ef6cdeb5adceaf
tree837822973701b1da714b2843f71a57cabb54d9c4
parentc8c7672ffb2d46fbfdfbbd014332428ca2f6446a
glupload: Only renegotiate if the caps are incompatible

There is new code that ensures that we renegotiate after an
uploader transition if the negotiated caps have changed.

The problem is that the raw uploader will not really try and
fixate the input caps, but instead of return a subset with the
only the supported target texture.

This had two effect, raw uploads was always done renegotiated
once and the raw upload unit test was now failing as it didn't
expect a renegotiation.

As it's a valid check, simply relax the gst_caps_is_equal() check
and use a gst_caps_is_subset() instead.

https://bugzilla.gnome.org/show_bug.cgi?id=783521
gst-libs/gst/gl/gstglupload.c