usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check
authorColin Ian King <colin.king@canonical.com>
Thu, 21 May 2020 15:13:00 +0000 (16:13 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 30 Jun 2020 19:38:27 +0000 (15:38 -0400)
commite03c43a1e88a788c19350a26e178db583fa60817
treed76204bacc129495c87269a4bf05747c1e906d27
parentfd554743e85b7d98c7a0684cd0f2a41cbfc26b22
usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check

[ Upstream commit eafa80041645cd7604c4357b1a0cd4a3c81f2227 ]

Currently pointer ep is being dereferenced before it is null checked
leading to a null pointer dereference issue.  Fix this by only assigning
pointer udc once ep is known to be not null.  Also remove a debug
message that requires a valid udc which may not be possible at that
point.

Addresses-Coverity: ("Dereference before null check")
Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/udc/lpc32xx_udc.c