drm/msm: Fix possible uninitialized access in fbdev
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 22 Feb 2023 12:37:12 +0000 (13:37 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 22 Feb 2023 16:12:36 +0000 (17:12 +0100)
commite034b8a18d4badceecb672c58b488bad1e901d95
tree824a208fda6edc1fe197f321f090e07c4a3f7a49
parent3fb1f62f80a1d249260db5ea9e22c51e52fab9ae
drm/msm: Fix possible uninitialized access in fbdev

Do not run drm_fb_helper_unprepare() if fbdev allocation fails. Avoids
access to an uninitialized pointer. Original bug report is at [1].

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 3fb1f62f80a1 ("drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()")
Link: https://lore.kernel.org/oe-kbuild-all/202302220810.9dymwCQ8-lkp@intel.com/
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230222123712.5049-1-tzimmermann@suse.de
drivers/gpu/drm/msm/msm_fbdev.c