udp: Fix a memory leak in udp_read_sock()
authorCong Wang <cong.wang@bytedance.com>
Tue, 15 Jun 2021 02:13:37 +0000 (19:13 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 21 Jun 2021 14:48:24 +0000 (16:48 +0200)
commite00a5c331bf57f41fcfdc5da4f5caeafe5e54c1d
tree6f0ad4fe45fb3f3edf9ba7427d63d527a363722d
parenta7e65fe7d8201527129206754db1a2db6a6b2fde
udp: Fix a memory leak in udp_read_sock()

sk_psock_verdict_recv() clones the skb and uses the clone
afterward, so udp_read_sock() should free the skb after using
it, regardless of error or not.

This fixes a real kmemleak.

Fixes: d7f571188ecf ("udp: Implement ->read_sock() for sockmap")
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/20210615021342.7416-4-xiyou.wangcong@gmail.com
net/ipv4/udp.c