selftests/efivarfs: clean up test files from test_create*()
authorPo-Hsu Lin <po-hsu.lin@canonical.com>
Fri, 19 Apr 2019 14:04:49 +0000 (22:04 +0800)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 19 Apr 2019 23:17:19 +0000 (17:17 -0600)
commitdff6d2ae56d0056261e2f7b19c4b96b86b893cd8
tree9ed7074981ce057e7b6060a353f70a3ed4ce1c0d
parent8ce72dc32578f16942997f041f62759b4c693b6f
selftests/efivarfs: clean up test files from test_create*()

Test files created by test_create() and test_create_empty() tests will
stay in the $efivarfs_mount directory until the system was rebooted.

When the tester tries to run this efivarfs test again on the same
system, the immutable characteristics in that directory will cause some
"Operation not permitted" noises, and a false-positve test result as the
file was created in previous run.
    --------------------
    running test_create
    --------------------
    ./efivarfs.sh: line 59: /sys/firmware/efi/efivars/test_create-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
      [PASS]
    --------------------
    running test_create_empty
    --------------------
    ./efivarfs.sh: line 78: /sys/firmware/efi/efivars/test_create_empty-210be57c-9849-4fc7-a635-e6382d1aec27: Operation not permitted
     [PASS]
    --------------------

Create a file_cleanup() to remove those test files in the end of each
test to solve this issue.

For the test_create_read, we can move the clean up task to the end of
the test to ensure the system is clean.

Also, use this function to replace the existing file removal code.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/efivarfs/efivarfs.sh