bpf: Prevent mmap()'ing read-only maps as writable
authorAndrii Nakryiko <andriin@fb.com>
Tue, 19 May 2020 05:38:24 +0000 (22:38 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Thu, 21 May 2020 03:21:53 +0000 (20:21 -0700)
commitdfeb376dd4cb2c5004aeb625e2475f58a5ff2ea7
tree641c6f335575c230f294743042295a404e1e3aee
parent0550cfe8c2c6f8e7a4c348b6603a794576db12dd
bpf: Prevent mmap()'ing read-only maps as writable

As discussed in [0], it's dangerous to allow mapping BPF map, that's meant to
be frozen and is read-only on BPF program side, because that allows user-space
to actually store a writable view to the page even after it is frozen. This is
exacerbated by BPF verifier making a strong assumption that contents of such
frozen map will remain unchanged. To prevent this, disallow mapping
BPF_F_RDONLY_PROG mmap()'able BPF maps as writable, ever.

  [0] https://lore.kernel.org/bpf/CAEf4BzYGWYhXdp6BJ7_=9OQPJxQpgug080MMjdSB72i9R+5c6g@mail.gmail.com/

Fixes: fc9702273e2e ("bpf: Add mmap() support for BPF_MAP_TYPE_ARRAY")
Suggested-by: Jann Horn <jannh@google.com>
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Jann Horn <jannh@google.com>
Link: https://lore.kernel.org/bpf/20200519053824.1089415-1-andriin@fb.com
kernel/bpf/syscall.c
tools/testing/selftests/bpf/prog_tests/mmap.c
tools/testing/selftests/bpf/progs/test_mmap.c