fpga: m10bmc-sec: Fix kconfig dependencies
authorRuss Weight <russell.h.weight@intel.com>
Tue, 15 Nov 2022 00:11:27 +0000 (16:11 -0800)
committerXu Yilun <yilun.xu@intel.com>
Tue, 15 Nov 2022 13:46:58 +0000 (21:46 +0800)
commitdfd10332596ef11ceafd29c4e21b4117be423fc4
treec5d291f2436b0f3b1abb2bb7913965214a15c594
parent9abf2313adc1ca1b6180c508c25f22f9395cc780
fpga: m10bmc-sec: Fix kconfig dependencies

The secure update driver depends on the firmware-upload functionality of
the firmware-loader. The firmware-loader is carried in the firmware-class
driver which is enabled with the tristate CONFIG_FW_LOADER option. The
firmware-upload functionality is included in the firmware-class driver if
the bool FW_UPLOAD config is set.

The current dependency statement, "depends on FW_UPLOAD", is not adequate
because it does not implicitly turn on FW_LOADER. Instead of adding a
dependency, follow the convention used by drivers that require the
FW_LOADER_USER_HELPER functionality of the firmware-loader by using
select for both FW_LOADER and FW_UPLOAD.

Fixes: bdf86d0e6ca3 ("fpga: m10bmc-sec: create max10 bmc secure update")
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20221115001127.289890-1-russell.h.weight@intel.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
drivers/fpga/Kconfig