scsi: pm8001: Fix use-after-free for aborted SSP/STP sas_task
authorJohn Garry <john.garry@huawei.com>
Thu, 27 Jan 2022 13:12:52 +0000 (21:12 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 31 Jan 2022 21:40:07 +0000 (16:40 -0500)
commitdf7abcaa1246e2537ab4016077b5443bb3c09378
tree813f446b5a04025df6d43112c625547fec5d5ca9
parent61f162aa4381845acbdc7f2be4dfb694d027c018
scsi: pm8001: Fix use-after-free for aborted SSP/STP sas_task

Currently a use-after-free may occur if a sas_task is aborted by the upper
layer before we handle the I/O completion in mpi_ssp_completion() or
mpi_sata_completion().

In this case, the following are the two steps in handling those I/O
completions:

 - Call complete() to inform the upper layer handler of completion of
   the I/O.

 - Release driver resources associated with the sas_task in
   pm8001_ccb_task_free() call.

When complete() is called, the upper layer may free the sas_task. As such,
we should not touch the associated sas_task afterwards, but we do so in the
pm8001_ccb_task_free() call.

Fix by swapping the complete() and pm8001_ccb_task_free() calls ordering.

Link: https://lore.kernel.org/r/1643289172-165636-4-git-send-email-john.garry@huawei.com
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm80xx_hwi.c