drm/i915: Display WA #1185 WaDisableDARBFClkGating:cnl, glk
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Sat, 11 Nov 2017 00:03:19 +0000 (16:03 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 14 Nov 2017 16:47:25 +0000 (08:47 -0800)
commitdf49ec8223050d510bd243d85c51139fc101029f
tree3169a7be5dc6c3e69a0d1f15d783ae917ece1c7e
parent176d5325d1a7d088e96cfef898fa7d3a622a6903
drm/i915: Display WA #1185 WaDisableDARBFClkGating:cnl, glk

Display is not sending a PMRsp when a PMReq is received
at the same time that all planes are turned off.
State machine in the dcprunit is stuck in the WAIT4DONE
state which means that there is no fill_done.

WA: disable arbiter clock gating, set bit [27] of 0x46530

v2: As Ville pointed out, based on the description the issue
    can happen when disabling the planes, similar to
    WaRsPkgCStateDisplayPMReq:hsw
    Also description of the issue was updated on commit
    message to make it more clear that we need this
    earlier.
v3: Restore comment about possibility to system hang
    to where we are sure about it, without speculation. (Ville).
v4: Remove doubled sob. Actually do v3 changes :/

Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171111000319.5040-1-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_display.c