drm/i915/guc: Drop guc->interrupts.enabled
authorMatthew Brost <matthew.brost@intel.com>
Thu, 3 Jun 2021 05:16:16 +0000 (22:16 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 3 Jun 2021 21:31:45 +0000 (23:31 +0200)
commitded32d381cbb06e9cc8915dbcb92be941e195cda
tree7aafdf429472a9e246c1ae5ca35b142e190f0d57
parent0a8e247dc1fa7a4b1e91b41f833f2a5f14c6d3f3
drm/i915/guc: Drop guc->interrupts.enabled

Drop the variable guc->interrupts.enabled as this variable is just
leading to bugs creeping into the code.

e.g. A full GPU reset disables the GuC interrupts but forgot to clear
guc->interrupts.enabled, guc->interrupts.enabled being true suppresses
interrupts from getting re-enabled and now we are broken.

It is harmless to enable interrupt while already enabled so let's just
delete this variable to avoid bugs like this going forward.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210603051630.2635-7-matthew.brost@intel.com
drivers/gpu/drm/i915/gt/uc/intel_guc.c
drivers/gpu/drm/i915/gt/uc/intel_guc.h