samples/seccomp: Zero out members based on seccomp_notif_sizes
authorSargun Dhillon <sargun@sargun.me>
Mon, 30 Dec 2019 20:35:03 +0000 (12:35 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 09:19:57 +0000 (10:19 +0100)
commitde7cd9dfc578e8b1f6586ffbc0e24683c356d143
treea1dcde9293b3d8b70be9e6ab59e8c66a855c5a1e
parentf75e60d239087a582ca3d828fb475422d8046b79
samples/seccomp: Zero out members based on seccomp_notif_sizes

commit 771b894f2f3dfedc2ba5561731fffa0e39b1bbb6 upstream.

The sizes by which seccomp_notif and seccomp_notif_resp are allocated are
based on the SECCOMP_GET_NOTIF_SIZES ioctl. This allows for graceful
extension of these datastructures. If userspace zeroes out the
datastructure based on its version, and it is lagging behind the kernel's
version, it will end up sending trailing garbage. On the other hand,
if it is ahead of the kernel version, it will write extra zero space,
and potentially cause corruption.

Signed-off-by: Sargun Dhillon <sargun@sargun.me>
Suggested-by: Tycho Andersen <tycho@tycho.ws>
Link: https://lore.kernel.org/r/20191230203503.4925-1-sargun@sargun.me
Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
samples/seccomp/user-trap.c