ASoC: SOF: ipc4-topology: Clarify bind failure caused by missing fw_module
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Mon, 3 Apr 2023 09:09:09 +0000 (12:09 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 3 Apr 2023 11:13:44 +0000 (12:13 +0100)
commitde6aa72b265b72bca2b1897d5000c8f0147d3157
tree34ce1d4c267f01b4a039e79524e581d7f9563025
parente3720f92e0237921da537e47a0b24e27899203f8
ASoC: SOF: ipc4-topology: Clarify bind failure caused by missing fw_module

The original patch uses a feature in lib/vsprintf.c to handle the invalid
address when tring to print *_fw_module->man4_module_entry.name when the
*rc_fw_module is NULL.
This case is handled by check_pointer_msg() internally and turns the
invalid pointer to '(efault)' for printing but it is hiding useful
information about the circumstances. Change the print to emmit the name
of the widget and a note on which side's fw_module is missing.

Fixes: e3720f92e023 ("ASoC: SOF: avoid a NULL dereference with unsupported widgets")
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/alsa-devel/4826f662-42f0-4a82-ba32-8bf5f8a03256@kili.mountain/
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.'
Link: https://lore.kernel.org/r/20230403090909.18233-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-topology.c