tipc: stop tipc crypto on failure in tipc_node_create
authorFedor Pchelkin <pchelkin@ispras.ru>
Tue, 25 Jul 2023 21:46:25 +0000 (00:46 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 27 Jul 2023 09:45:05 +0000 (11:45 +0200)
commitde52e17326c3e9a719c9ead4adb03467b8fae0ef
treed0281c07daec6a60956a77d71a3f1f791965e180
parentecb4534b6a1c8a9c01d4d1d532d58fc18f23c8da
tipc: stop tipc crypto on failure in tipc_node_create

If tipc_link_bc_create() fails inside tipc_node_create() for a newly
allocated tipc node then we should stop its tipc crypto and free the
resources allocated with a call to tipc_crypto_start().

As the node ref is initialized to one to that point, just put the ref on
tipc_link_bc_create() error case that would lead to tipc_node_free() be
eventually executed and properly clean the node and its crypto resources.

Found by Linux Verification Center (linuxtesting.org).

Fixes: cb8092d70a6f ("tipc: move bc link creation back to tipc_node_create")
Suggested-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/20230725214628.25246-1-pchelkin@ispras.ru
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/tipc/node.c