NFC: hci: Split memcpy() of struct hcp_message flexible array
authorKees Cook <keescook@chromium.org>
Sat, 24 Sep 2022 04:08:35 +0000 (21:08 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Sep 2022 14:45:18 +0000 (07:45 -0700)
commitde4feb4e3d61026f81b15ada6f64deaf40125ffc
tree592cc0d923b1c86654465d4b0bcf8ee0e6ca92fe
parent454b20e19322e6a9375cbaad68fff3c93bd27716
NFC: hci: Split memcpy() of struct hcp_message flexible array

To work around a misbehavior of the compiler's ability to see into
composite flexible array structs (as detailed in the coming memcpy()
hardening series[1]), split the memcpy() of the header and the payload
so no false positive run-time overflow warning will be generated. This
split already existed for the "firstfrag" case, so just generalize the
logic further.

[1] https://lore.kernel.org/linux-hardening/20220901065914.1417829-2-keescook@chromium.org/

Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Reported-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220924040835.3364912-1-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/nfc/hci/hcp.c