ALSA: hda: Remove redundant runtime PM calls
authorTakashi Iwai <tiwai@suse.de>
Fri, 19 Nov 2021 16:27:30 +0000 (17:27 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 20 Nov 2021 08:04:47 +0000 (09:04 +0100)
commitde2f29c4394efa64c3a5ba1b15302eb558ed4c56
tree6e011828e74e563d6dd0e479a8609fc063569964
parent37c4fd0db7c961145d9d1909ecab386fdf703c26
ALSA: hda: Remove redundant runtime PM calls

The previous fix for more comprehensive runtime PM calls turned out to
be not good as hoped; a few calls including pm_runtime_enable() and
pm_runtime_disable() are rather utterly superfluous for PCI devices,
even triggering a kernel error message.  Better to drop those calls.

Note that the problem we wanted to solve with that commit seems
irrelevant with the fix itself; the original bug (a GPF at
azx_remove()) was likely a regression by the recent PCI core cleanup,
and the buggy PCI change has been already reverted.  So basically we
were scratching a wrong surface.  OTOH, making the runtime PM calls
symmetric for both probe and remove is more consistent, and maybe
that's a sensible outcome.

Fixes: 4f66a9ef37d3 ("ALSA: hda: intel: More comprehensive PM runtime setup for controller driver")
Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/d9d76980-966a-e031-70d1-3254ba5be5eb@gmail.com
Link: https://lore.kernel.org/r/20211119162730.24423-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_intel.c