Fix EventSource trimmer warning (#51237)
authorLakshan Fernando <lakshanf@hotmail.com>
Tue, 20 Apr 2021 12:07:36 +0000 (05:07 -0700)
committerGitHub <noreply@github.com>
Tue, 20 Apr 2021 12:07:36 +0000 (05:07 -0700)
commitddaa1c3c503f989db48102f50a693765e4e6ae2a
tree8178c86ccb5ebcb001a751789a9d88b2cdc61a71
parentf9ce10f9d3423e80b3c87c363718a320f14d55f0
Fix EventSource trimmer warning (#51237)

* eh fix

* test change that inadvertently got checked in earlier

* Suppresses the trimmer warning on TypeAnalysis ctor

* Incorporating FB

* Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
* Fix DynamicDependency as per PR feedback

* an earlier change got reverted

* fixed proj file netcore app condition check

* fixed NETCORE_ENGINEERING_TELEMETRY build failures

* fixeing another NETCORE_ENGINEERING_TELEMETRY build failures

* Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppressing the warning to get FB, not fully fixed

* PR FB and suppressing warnings for safe calls

* propagated the warning all the way up

* CI build break fix for one file

* excluding NativeRTEventSrc from being build in a project

* Missed couple of supppressions on NativeRTEventSrc

* build break fixes

* Trimmer warning fix related to EventSource manifest creation

* incorporate fb

* fix build break in some configs

* comment feedback

* build break

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
src/libraries/System.Diagnostics.Tracing/ref/System.Diagnostics.Tracing.cs
src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.Shared.xml
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs