Revert "net/mlx5e: MACsec, remove replay window size limitation in offload path"
authorSaeed Mahameed <saeedm@nvidia.com>
Tue, 29 Nov 2022 09:30:05 +0000 (01:30 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Nov 2022 16:19:59 +0000 (08:19 -0800)
commitdda3bbbb26c823cd54d5bf211df7db12147c9392
treeacdb675190c6b9bd0ffdb6911f5fb051c72b61fc
parente493bec343fa76e95631d0e21fd4a3538aa90c56
Revert "net/mlx5e: MACsec, remove replay window size limitation in offload path"

This reverts commit c0071be0e16c461680d87b763ba1ee5e46548fde.

The cited commit removed the validity checks which initialized the
window_sz and never removed the use of the now uninitialized variable,
so now we are left with wrong value in the window size and the following
clang warning: [-Wuninitialized]
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c:232:45:
       warning: variable 'window_sz' is uninitialized when used here
       MLX5_SET(macsec_aso, aso_ctx, window_size, window_sz);

Revet at this time to address the clang issue due to lack of time to
test the proper solution.

Fixes: c0071be0e16c ("net/mlx5e: MACsec, remove replay window size limitation in offload path")
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reported-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20221129093006.378840-1-saeed@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
include/linux/mlx5/mlx5_ifc.h