Fix incorrect layout transition in render pass
authorPiers Daniell <pdaniell@nvidia.com>
Tue, 13 Aug 2019 22:11:23 +0000 (16:11 -0600)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Thu, 22 Aug 2019 11:24:54 +0000 (07:24 -0400)
commitdd931b1d5b6372e3e8255475aeca34ad5a23c565
tree8e79209b71e040f9b1fc2e5e0c3ea2190271bd5c
parent51752039d649ec9ce37ae481a0695544f04622d8
Fix incorrect layout transition in render pass

For the dEQP-VK.device_group.* tests the renderImage was
created with an UNDEFINED layout and then explicitly
transitioned to COLOR_ATTACHMENT_OPTIMAL during the test
initialization. Then the renderPass was created using the
makeRenderPass() utility function which assumed the
image was in the UNDEFINED state. This caused the
image to be transitioned again from UNDEFINED
to COLOR_ATTACHMENT_OPTIMAL at begin render pass time,
which might modify any valid image data.

The solution is to fix the render pass creation
to indicate that the renderImage is already in the
COLOR_ATTACHMENT_OPTIMAL layout.

Affects:

dEQP-VK.device_group.*

VK-GL-CTS issue: 1922

Change-Id: I5e1dff19eb854af9651615a7318379a318b8c273
Components: Vulkan
external/vulkancts/modules/vulkan/device_group/vktDeviceGroupRendering.cpp