block: fix blktrace debugfs entries leakage
authorYu Kuai <yukuai3@huawei.com>
Sat, 10 Jun 2023 02:20:03 +0000 (10:20 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 15 Jun 2023 02:24:03 +0000 (20:24 -0600)
commitdd7de3704af9989b780693d51eaea49a665bd9c2
tree7b42d8662e6287cb7271b5da027eeecaee6dedb5
parentdb59133e927916d8a25ee1fd8264f2808040909d
block: fix blktrace debugfs entries leakage

Commit 99d055b4fd4b ("block: remove per-disk debugfs files in
blk_unregister_queue") moves blk_trace_shutdown() from
blk_release_queue() to blk_unregister_queue(), this is safe if blktrace
is created through sysfs, however, there is a regression in corner
case.

blktrace can still be enabled after del_gendisk() through ioctl if
the disk is opened before del_gendisk(), and if blktrace is not shutdown
through ioctl before closing the disk, debugfs entries will be leaked.

Fix this problem by shutdown blktrace in disk_release(), this is safe
because blk_trace_remove() is reentrant.

Fixes: 99d055b4fd4b ("block: remove per-disk debugfs files in blk_unregister_queue")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230610022003.2557284-4-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/genhd.c