ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink > 0' for host inode
authorZhihao Cheng <chengzhihao1@huawei.com>
Mon, 17 Aug 2020 14:29:09 +0000 (22:29 +0800)
committerRichard Weinberger <richard@nod.at>
Thu, 17 Sep 2020 20:56:09 +0000 (22:56 +0200)
commitdd7db149bcd914db8fdeb19cd5597c0740121bc7
tree42c4d735df65cc5879a0e9b9d832d8bf3b36bfb0
parentd005f8c6588efcfbe88099b6edafc6f58c84a9c1
ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink > 0' for host inode

Changing xattr of a temp file will trigger following assertion failed
and make ubifs turn into readonly filesystem:
  ubifs_assert_failed [ubifs]: UBIFS assert failed: host->i_nlink > 0,
  in fs/ubifs/journal.c:1801

Reproducer:
  1. fd = open(__O_TMPFILE)
  2. fsetxattr(fd, key, value2, XATTR_CREATE)
  3. fsetxattr(fd, key, value2, XATTR_REPLACE)

Fix this by removing assertion 'nlink > 0' for host inode.

Reported-by: Chengsong Ke <kechengsong@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/journal.c