xfrm: Fix xfrm offload fallback fail case
authorAyush Sawal <ayush.sawal@chelsio.com>
Tue, 22 Jun 2021 03:55:31 +0000 (09:25 +0530)
committerSteffen Klassert <steffen.klassert@secunet.com>
Tue, 22 Jun 2021 07:08:15 +0000 (09:08 +0200)
commitdd72fadf2186fc8a6018f97fe72f4d5ca05df440
treebe69d4bc2741704da8e86704a1080ebd05c9b48b
parent6fd06963fa74197103cdbb4b494763127b3f2f34
xfrm: Fix xfrm offload fallback fail case

In case of xfrm offload, if xdo_dev_state_add() of driver returns
-EOPNOTSUPP, xfrm offload fallback is failed.
In xfrm state_add() both xso->dev and xso->real_dev are initialized to
dev and when err(-EOPNOTSUPP) is returned only xso->dev is set to null.

So in this scenario the condition in func validate_xmit_xfrm(),
if ((x->xso.dev != dev) && (x->xso.real_dev == dev))
                return skb;
returns true, due to which skb is returned without calling esp_xmit()
below which has fallback code. Hence the CRYPTO_FALLBACK is failing.

So fixing this with by keeping x->xso.real_dev as NULL when err is
returned in func xfrm_dev_state_add().

Fixes: bdfd2d1fa79a ("bonding/xfrm: use real_dev instead of slave_dev")
Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_device.c