AMDGPU: fix overlapping copies in copyPhysReg
authorNicolai Haehnle <nhaehnle@gmail.com>
Sat, 19 Dec 2015 01:16:06 +0000 (01:16 +0000)
committerNicolai Haehnle <nhaehnle@gmail.com>
Sat, 19 Dec 2015 01:16:06 +0000 (01:16 +0000)
commitdd58705af6442226b9de3adab18f826623c5af51
treeedfafb61194dd83f5fbbeb51811811d9ddd9b4ec
parent14c50288ccf100c97bf451cc2a5d7a95d7ddc067
AMDGPU: fix overlapping copies in copyPhysReg

Summary:
When copying aggregate registers within the same register class, there may
be an overlap between source and destination that forces us to do the copy
backwards.

Do the simplest possible thing that guarantees the correct order of moves
when there are overlaps, and does whatever when there is no overlap. (The
last part forces some trivial adjustments to test cases.)

Together with r255906, this fixes a VM fault in Unreal Elemental Demo.

While at it, change the generation of kill and def flags to something that
looks more reasonable. This method is used very late during compilation, so
it probably doesn't matter in practice, and to be honest, I don't know if
this change is actually correct because the semantics in connection with
aggregate registers vs. sub-registers are not clear to me.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93264

Reviewers: arsenm, tstellarAMD

Subscribers: arsenm, llvm-commits

Differential Revision: http://reviews.llvm.org/D15622

llvm-svn: 256072
llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
llvm/test/CodeGen/AMDGPU/ctpop64.ll
llvm/test/CodeGen/AMDGPU/flat-address-space.ll