[DSE] Remove no-data-layout-only type-based overlap checking
authorHal Finkel <hfinkel@anl.gov>
Fri, 17 Oct 2014 11:56:00 +0000 (11:56 +0000)
committerHal Finkel <hfinkel@anl.gov>
Fri, 17 Oct 2014 11:56:00 +0000 (11:56 +0000)
commitdd38c0b876dc5f1525b1e2e43e46e0e43d229c5b
treec8526080141387870dc3e0c028ef1b4aa9b24710
parentaa3e9f5a0f45dd0736c831dfb2607df05dab627c
[DSE] Remove no-data-layout-only type-based overlap checking

DSE's overlap checking contained special logic, used only when no DataLayout
was available, which inferred a complete overwrite when the pointee types were
equal. This logic seems fine for regular loads/stores, but does not work for
memcpy and friends. Instead of fixing this, I'm just removing it.
Philosophically, transformations should not contain enhanced behavior used only
when data layout is lacking (data layout should be strictly additive), and
maintaining these rarely-tested code paths seems not worthwhile at this stage.

Credit to Aliaksei Zasenka for the bug report and the diagnosis. The test case
(slightly reduced from that provided by Aliaksei) replaces the original
contents of test/Transforms/DeadStoreElimination/no-targetdata.ll -- a few
other tests have been updated to have a data layout.

llvm-svn: 220035
llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
llvm/test/Analysis/TypeBasedAliasAnalysis/dse.ll
llvm/test/Transforms/DeadStoreElimination/const-pointers.ll
llvm/test/Transforms/DeadStoreElimination/inst-limits.ll
llvm/test/Transforms/DeadStoreElimination/no-targetdata.ll