Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
authorjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jan 2012 04:15:06 +0000 (04:15 +0000)
committerjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 24 Jan 2012 04:15:06 +0000 (04:15 +0000)
commitdd34df484ab36af6f2226acac7d7dbc658321c15
treefbe899a931c427e3277e87a152c7f7e35bf9473c
parent23359ecd3949ea5d0f2a7b8b4f25c09b172b06b1
Crash in WebCore::RenderTableSection::rowLogicalHeightChanged
https://webkit.org/b/76842

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/table/crash-section-logical-height-changed-needsCellRecalc.html

The issue was that we would access our section's structure when it was dirty.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
Bail out if we need cells recalculation as our internal structure is not up-to-date
and we will recompute all the rows' heights as part of the recomputation anyway.

LayoutTests:

* fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt: Added.
* fast/table/crash-section-logical-height-changed-needsCellRecalc.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/ChangeLog
LayoutTests/fast/table/crash-section-logical-height-changed-needsCellRecalc-expected.txt [new file with mode: 0644]
LayoutTests/fast/table/crash-section-logical-height-changed-needsCellRecalc.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTableSection.cpp