getaddrinfo: Fix use after free in getcanonname (CVE-2023-4806) 17/299617/1
authorSiddhesh Poyarekar <siddhesh@sourceware.org>
Fri, 15 Sep 2023 17:51:12 +0000 (13:51 -0400)
committerSlava Barinov <v.barinov@samsung.com>
Thu, 5 Oct 2023 09:49:25 +0000 (12:49 +0300)
commitdcf2cc00accbeacad503f72c48e2e49a9eab7ed8
tree469960b55e320fceb838f7bc063a1e35fd2a74b1
parent44625c3b6b65d24027fd733006fb2f5a4c31d97b
getaddrinfo: Fix use after free in getcanonname (CVE-2023-4806)

When an NSS plugin only implements the _gethostbyname2_r and
_getcanonname_r callbacks, getaddrinfo could use memory that was freed
during tmpbuf resizing, through h_name in a previous query response.

The backing store for res->at->name when doing a query with
gethostbyname3_r or gethostbyname2_r is tmpbuf, which is reallocated in
gethosts during the query.  For AF_INET6 lookup with AI_ALL |
AI_V4MAPPED, gethosts gets called twice, once for a v6 lookup and second
for a v4 lookup.  In this case, if the first call reallocates tmpbuf
enough number of times, resulting in a malloc, th->h_name (that
res->at->name refers to) ends up on a heap allocated storage in tmpbuf.
Now if the second call to gethosts also causes the plugin callback to
return NSS_STATUS_TRYAGAIN, tmpbuf will get freed, resulting in a UAF
reference in res->at->name.  This then gets dereferenced in the
getcanonname_r plugin call, resulting in the use after free.

Fix this by copying h_name over and freeing it at the end.  This
resolves BZ #30843, which is assigned CVE-2023-4806.

Change-Id: I60f3106d2045ff78b80993e7a5c9f85235955bc6
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Commit: 973fe93a5675c42798b2161c6f29c01b0e243994
nss/Makefile
nss/nss_test_gai_hv2_canonname.c [new file with mode: 0644]
nss/tst-nss-gai-hv2-canonname.c [new file with mode: 0644]
nss/tst-nss-gai-hv2-canonname.h [new file with mode: 0644]
nss/tst-nss-gai-hv2-canonname.root/postclean.req [new file with mode: 0644]
nss/tst-nss-gai-hv2-canonname.root/tst-nss-gai-hv2-canonname.script [new file with mode: 0644]
sysdeps/posix/getaddrinfo.c