[GWP-ASan] Fix up bad report for in-page underflow w/ UaF
authorMitch Phillips <31459023+hctim@users.noreply.github.com>
Tue, 10 Jan 2023 18:29:49 +0000 (10:29 -0800)
committerMitch Phillips <31459023+hctim@users.noreply.github.com>
Tue, 10 Jan 2023 18:29:49 +0000 (10:29 -0800)
commitdcf23e13615f88bdd4975058595ee60cf1d5811c
treea1e77ef0d7b8eb321ba8e1b39729c705fc490179
parent296f7fbbb5c48a961aa31b2ffa1d048e6bfbd7a1
[GWP-ASan] Fix up bad report for in-page underflow w/ UaF

Complex scenario, but reports when there's both a use-after-free and
buffer-underflow that is in-page (i.e. doesn't touch the guard page)
ended up generating a pretty bad report:

'Use After Free at 0x7ff392e88fef (18446744073709551615 bytes into a
1-byte allocation at 0x7ff392e88ff0) by thread 3836722 here:'

(note the 2^64-bytes-into-alloc, very cool and good!)

Fix up that case, and add a diagnostic about when you have both a
use-after-free and a buffer-overflow that it's probably a bogus report
(assuming the developer didn't *really* screw up and have a uaf+overflow
bug at the same time).

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D139885
compiler-rt/lib/gwp_asan/crash_handler.cpp
compiler-rt/lib/gwp_asan/optional/segv_handler_posix.cpp
compiler-rt/test/gwp_asan/free_then_overflow.cpp [new file with mode: 0644]
compiler-rt/test/gwp_asan/free_then_underflow.cpp [new file with mode: 0644]
compiler-rt/test/gwp_asan/heap_buffer_overflow.cpp
compiler-rt/test/gwp_asan/heap_buffer_underflow.cpp