tracing: Add field modifier parsing hist error for hist triggers
authorTom Zanussi <tom.zanussi@linux.intel.com>
Fri, 27 Apr 2018 01:04:49 +0000 (20:04 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 27 Apr 2018 01:39:58 +0000 (21:39 -0400)
commitdcf234577cd31fa16874e828b90659166ad6b80d
tree34dc3ae4434369feb26c4572eca34c64cd71575e
parent5ec432d7bf9dd3b4a2b84f8974e3adb71f45fb1d
tracing: Add field modifier parsing hist error for hist triggers

If the user specifies an invalid field modifier for a hist trigger,
the current code correctly flags that as an error, but doesn't tell
the user what happened.

Fix this by invoking hist_err() with an appropriate message when
invalid modifiers are specified.

Before:

  # echo 'hist:keys=pid:ts0=common_timestamp.junkusecs' >> /sys/kernel/debug/tracing/events/sched/sched_wakeup/trigger
  -su: echo: write error: Invalid argument
  # cat /sys/kernel/debug/tracing/events/sched/sched_wakeup/hist

After:

  # echo 'hist:keys=pid:ts0=common_timestamp.junkusecs' >> /sys/kernel/debug/tracing/events/sched/sched_wakeup/trigger
  -su: echo: write error: Invalid argument
  # cat /sys/kernel/debug/tracing/events/sched/sched_wakeup/hist
  ERROR: Invalid field modifier: junkusecs
    Last command: keys=pid:ts0=common_timestamp.junkusecs

Link: http://lkml.kernel.org/r/b043c59fa79acd06a5f14a1d44dee9e5a3cd1248.1524790601.git.tom.zanussi@linux.intel.com
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c