mmc: sunplus: fix return value check of mmc_add_host()
authorWei Chen <harperchen1110@gmail.com>
Thu, 22 Jun 2023 09:02:33 +0000 (09:02 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 9 Aug 2023 11:12:53 +0000 (13:12 +0200)
commitdce6d8f985fa1ef5c2af47f4f86ea65511b78656
tree093c794c359696c37e738b5865612e82e2f5c77d
parentd83035433701919ac6db15f7737cbf554c36c1a6
mmc: sunplus: fix return value check of mmc_add_host()

mmc_add_host() may return error, if we ignore its return value,
1. the memory allocated in mmc_alloc_host() will be leaked
2. null-ptr-deref will happen when calling mmc_remove_host()
in remove function spmmc_drv_remove() because deleting not
added device.

Fix this by checking the return value of mmc_add_host(). Moreover,
I fixed the error handling path of spmmc_drv_probe() to clean up.

Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021")
Cc: stable@vger.kernel.org
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Link: https://lore.kernel.org/r/20230622090233.188539-1-harperchen1110@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sunplus-mmc.c