scsi: iscsi: Fix inappropriate use of put_device()
authorQinglang Miao <miaoqinglang@huawei.com>
Fri, 20 Nov 2020 07:48:52 +0000 (15:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:42 +0000 (11:53 +0100)
commitdcda662622b17adaec14a1a6d82bf09e87b9ce11
tree2539f5c467fe5f7c1fa01a91e7605a44fd832670
parentf6d844be9502ae6ea90a603f349be332ef9e5841
scsi: iscsi: Fix inappropriate use of put_device()

[ Upstream commit 6dc1c7ab6f047f45b62986ffebc5324e86ed5f5a ]

kfree(conn) is called inside put_device(&conn->dev) which could lead to
use-after-free. In addition, device_unregister() should be used here rather
than put_deviceO().

Link: https://lore.kernel.org/r/20201120074852.31658-1-miaoqinglang@huawei.com
Fixes: f3c893e3dbb5 ("scsi: iscsi: Fail session and connection on transport registration failure")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/scsi_transport_iscsi.c