nleobject: stop using media-duration-factor
authorHenry Wilkes <hwilkes@igalia.com>
Wed, 8 Apr 2020 16:11:14 +0000 (17:11 +0100)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 29 Apr 2020 12:32:52 +0000 (12:32 +0000)
commitdc9dbddbaef35add56148cb683272deeae01826d
tree74363990749928c0a4d4d66980b9eea619b45350
parent2794ec836f6e534923b607f81dec6bf41b56a6b9
nleobject: stop using media-duration-factor

The property had been deprecated and is unused.

This property is not needed. Any internal time effect that an nleoperation
wraps is itself responsible for converting seek/segment timestamps.
Previously, the ghostpads were performing a rate conversion after the
rate element had already done so, essentially doubling their effect on
seeks and segment times. This was always unnecessary, but went unnoticed
by the tempochange test because it was using an identity element rather
than an actual rate-changing element.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/160>
ges/ges-effect.c
ges/ges-track-element.c
plugins/nle/nleghostpad.c
plugins/nle/nleobject.c
plugins/nle/nleobject.h
plugins/nle/nleoperation.c
tests/check/ges/tempochange.c
tests/check/nle/tempochange.c