[InstCombine] Remove ExpensiveCombines option
authorNikita Popov <nikita.ppv@gmail.com>
Sat, 21 Mar 2020 09:14:17 +0000 (10:14 +0100)
committerNikita Popov <nikita.ppv@gmail.com>
Sun, 22 Mar 2020 15:56:28 +0000 (16:56 +0100)
commitdc81923659c26f21821aaad215ac251034566faa
tree654b3f60b79d3ab2f8e0c2bcec7b95eabb1592ce
parent830cfda19f7a574cad16d5a27091abd35e3c1e59
[InstCombine] Remove ExpensiveCombines option

D75801 removed the last and only user of this option, so we can
drop it now. The original idea behind this was to only run expensive
transforms under -O3, but apart from the one known bits transform,
this has never really taken off. I believe nowadays the recommendation
is to put expensive transforms in AggressiveInstCombine instead,
though that isn't terribly popular either :)

Differential Revision: https://reviews.llvm.org/D76540
14 files changed:
llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h
llvm/include/llvm/Transforms/InstCombine/InstCombine.h
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
llvm/lib/Transforms/InstCombine/InstCombineInternal.h
llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
llvm/test/Transforms/InstCombine/all-bits-shift.ll
llvm/test/Transforms/InstCombine/assume.ll
llvm/test/Transforms/InstCombine/call-returned.ll
llvm/test/Transforms/InstCombine/expensive-combines.ll [deleted file]
llvm/test/Transforms/InstCombine/known-bits.ll
llvm/test/Transforms/InstCombine/known-signbit-shift.ll
llvm/test/Transforms/InstCombine/out-of-bounds-indexes.ll
llvm/test/Transforms/InstCombine/phi-shifts.ll
llvm/test/Transforms/InstCombine/pr44541.ll