Enable implicit fallthrough warning (#43397)
authorJan Vorlicek <janvorli@microsoft.com>
Wed, 21 Oct 2020 10:48:21 +0000 (12:48 +0200)
committerGitHub <noreply@github.com>
Wed, 21 Oct 2020 10:48:21 +0000 (12:48 +0200)
commitdc7b1d2c942b44bcdb2fbd12727a495cf8d57d9e
tree697d0d40ac4b814f26a2feecd1d05125adc82d0b
parent159a6ea8b5264e03632e3dc1bd12d4bdc7457b44
Enable implicit fallthrough warning (#43397)

* Enable implicit fallthrough warning

This change enables warnings for implicit fallthrough in
switch cases and fixes all the cases where the warning
was reported.
It also fixes some places where the fall through was incorrect.
Fortunately, these places were not causing functional issues.
94 files changed:
eng/native/configurecompiler.cmake
src/coreclr/src/ToolBox/superpmi/mcs/verbildump.cpp
src/coreclr/src/classlibnative/bcltype/varargsnative.cpp
src/coreclr/src/debug/di/rstype.cpp
src/coreclr/src/debug/ee/amd64/amd64walker.cpp
src/coreclr/src/debug/ee/controller.cpp
src/coreclr/src/debug/ee/debugger.cpp
src/coreclr/src/gc/unix/gcenv.unix.cpp
src/coreclr/src/ilasm/assem.cpp
src/coreclr/src/ilasm/assembler.cpp
src/coreclr/src/ilasm/prebuilt/asmparse.cpp
src/coreclr/src/ildasm/dasm.cpp
src/coreclr/src/ildasm/dasm_sz.cpp
src/coreclr/src/inc/palclr_win.h
src/coreclr/src/jit/assertionprop.cpp
src/coreclr/src/jit/codegenarmarch.cpp
src/coreclr/src/jit/codegencommon.cpp
src/coreclr/src/jit/codegenlinear.cpp
src/coreclr/src/jit/codegenxarch.cpp
src/coreclr/src/jit/compiler.cpp
src/coreclr/src/jit/compiler.h
src/coreclr/src/jit/compiler.hpp
src/coreclr/src/jit/disasm.cpp
src/coreclr/src/jit/eeinterface.cpp
src/coreclr/src/jit/emitarm.cpp
src/coreclr/src/jit/emitarm64.cpp
src/coreclr/src/jit/emitxarch.cpp
src/coreclr/src/jit/flowgraph.cpp
src/coreclr/src/jit/gentree.cpp
src/coreclr/src/jit/hwintrinsiccodegenarm64.cpp
src/coreclr/src/jit/hwintrinsicxarch.cpp
src/coreclr/src/jit/importer.cpp
src/coreclr/src/jit/inlinepolicy.cpp
src/coreclr/src/jit/instr.cpp
src/coreclr/src/jit/lclvars.cpp
src/coreclr/src/jit/lower.cpp
src/coreclr/src/jit/lowerxarch.cpp
src/coreclr/src/jit/lsraarm.cpp
src/coreclr/src/jit/lsraarm64.cpp
src/coreclr/src/jit/lsraxarch.cpp
src/coreclr/src/jit/morph.cpp
src/coreclr/src/jit/objectalloc.cpp
src/coreclr/src/jit/optcse.cpp
src/coreclr/src/jit/optimizer.cpp
src/coreclr/src/jit/simdashwintrinsic.cpp
src/coreclr/src/jit/simdcodegenxarch.cpp
src/coreclr/src/jit/valuenum.cpp
src/coreclr/src/jit/valuenum.h
src/coreclr/src/md/compiler/custattr_emit.cpp
src/coreclr/src/md/enc/stgio.cpp
src/coreclr/src/pal/inc/pal.h
src/coreclr/src/pal/inc/rt/sal.h
src/coreclr/src/pal/inc/rt/specstrings_undef.h
src/coreclr/src/pal/src/include/pal/palinternal.h
src/coreclr/src/pal/src/libunwind/CMakeLists.txt
src/coreclr/src/pal/src/safecrt/input.inl
src/coreclr/src/pal/src/safecrt/output.inl
src/coreclr/src/pal/src/safecrt/safecrt_output_l.cpp
src/coreclr/src/pal/src/thread/context.cpp
src/coreclr/src/utilcode/ilformatter.cpp
src/coreclr/src/utilcode/sstring.cpp
src/coreclr/src/utilcode/util.cpp
src/coreclr/src/vm/amd64/jitinterfaceamd64.cpp
src/coreclr/src/vm/callcounting.cpp
src/coreclr/src/vm/class.cpp
src/coreclr/src/vm/compile.cpp
src/coreclr/src/vm/customattribute.cpp
src/coreclr/src/vm/dllimport.cpp
src/coreclr/src/vm/eetoprofinterfaceimpl.cpp
src/coreclr/src/vm/excep.cpp
src/coreclr/src/vm/exceptmacros.h
src/coreclr/src/vm/fieldmarshaler.cpp
src/coreclr/src/vm/genericdict.cpp
src/coreclr/src/vm/invokeutil.cpp
src/coreclr/src/vm/jitinterface.cpp
src/coreclr/src/vm/methodtablebuilder.cpp
src/coreclr/src/vm/mlinfo.cpp
src/coreclr/src/vm/multicorejit.cpp
src/coreclr/src/vm/prestub.cpp
src/coreclr/src/vm/proftoeeinterfaceimpl.cpp
src/coreclr/src/vm/readytoruninfo.cpp
src/coreclr/src/vm/reflectioninvocation.cpp
src/coreclr/src/vm/siginfo.cpp
src/coreclr/src/vm/stubgen.cpp
src/coreclr/src/vm/stubmgr.cpp
src/coreclr/src/vm/threads.cpp
src/coreclr/src/vm/tieredcompilation.cpp
src/coreclr/src/vm/typeparse.cpp
src/coreclr/src/vm/util.cpp
src/coreclr/src/vm/zapsig.cpp
src/libraries/Native/Unix/CMakeLists.txt
src/libraries/Native/Unix/Common/pal_utilities.h
src/libraries/Native/Unix/System.IO.Compression.Native/CMakeLists.txt
src/libraries/Native/Unix/System.IO.Ports.Native/pal_termios.c